Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/SOF-6631: prepare libs for hp.x #33

Merged
merged 9 commits into from
Aug 26, 2023
Merged

feat/SOF-6631: prepare libs for hp.x #33

merged 9 commits into from
Aug 26, 2023

Conversation

pranabdas
Copy link
Contributor

No description provided.

@pranabdas pranabdas force-pushed the feat/SOF-6631 branch 4 times, most recently from b382088 to ee3187f Compare July 17, 2023 13:53
@pranabdas pranabdas force-pushed the feat/SOF-6631 branch 2 times, most recently from d6b1774 to 042bd2f Compare July 22, 2023 02:50
timurbazhirov
timurbazhirov reviewed Jul 22, 2023
View reviewed changes
src/application.js Outdated Show resolved Hide resolved
timurbazhirov
timurbazhirov reviewed Jul 22, 2023
View reviewed changes
src/application.js Outdated Show resolved Hide resolved
@pranabdas pranabdas force-pushed the feat/SOF-6631 branch 2 times, most recently from 971e407 to e1fb75a Compare August 13, 2023 01:51
@pranabdas pranabdas force-pushed the feat/SOF-6631 branch 3 times, most recently from 86b801e to 7f9eca8 Compare August 15, 2023 12:41
@pranabdas pranabdas marked this pull request as ready for review August 16, 2023 01:32
azech-hqs
azech-hqs reviewed Aug 16, 2023
View reviewed changes
src/application.js Outdated Show resolved Hide resolved
azech-hqs
azech-hqs reviewed Aug 16, 2023
View reviewed changes
src/executable.js Outdated Show resolved Hide resolved
azech-hqs
azech-hqs reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@azech-hqs azech-hqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes suggested, looks good otherwise.
Note: the version of application-flavors needs to be replaced with the published version before merging.

azech-hqs
azech-hqs reviewed Aug 16, 2023
View reviewed changes
src/executable.js Outdated Show resolved Hide resolved
timurbazhirov
timurbazhirov reviewed Aug 26, 2023
View reviewed changes
src/application.js Outdated Show resolved Hide resolved
timurbazhirov
timurbazhirov reviewed Aug 26, 2023
View reviewed changes
src/executable.js Outdated Show resolved Hide resolved
@timurbazhirov timurbazhirov merged commit 175dd91 into main Aug 26, 2023
4 checks passed
@pranabdas pranabdas deleted the feat/SOF-6631 branch August 26, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azech-hqs azech-hqs azech-hqs left review comments

@timurbazhirov timurbazhirov timurbazhirov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranabdas @timurbazhirov @azech-hqs