SOF-6631: avoid toJSON, simplify filters

Exabyte-io · Aug 16, 2023 · 4d4232a · 4d4232a
1 parent a43e150
commit 4d4232a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/src/application.js b/src/application.js
@@ -96,18 +96,18 @@ export class Application extends NamedDefaultableInMemoryEntity {
 
     get executables() {
         const tree = getAppTree(this.prop("name"));
-        const executableList = Object.keys(tree).map((key) => {
-            return new this.constructor.Executable({ ...tree[key], name: key });
-        });
-        const allowedExecutables = executableList.filter((exe) => {
-            const { supportedApplicationVersions } = exe.toJSON();
-            return (
-                !supportedApplicationVersions ||
-                (supportedApplicationVersions &&
-                    supportedApplicationVersions.includes(this.prop("version")))
-            );
-        });
-        return allowedExecutables;
+        return Object.keys(tree)
+            .filter((key) => {
+                const { supportedApplicationVersions } = tree[key];
+                return (
+                    !supportedApplicationVersions ||
+                    (supportedApplicationVersions &&
+                        supportedApplicationVersions.includes(this.prop("version")))
+                );
+            })
+            .map((key) => {
+                return new this.constructor.Executable({ ...tree[key], name: key });
+            });
     }
 
     get hasAdvancedComputeOptions() {

diff --git a/src/executable.js b/src/executable.js
@@ -42,9 +42,9 @@ export class Executable extends mix(NamedDefaultableInMemoryEntity).with(Runtime
         return config ? this.getFlavorByName(config.name) : this.defaultFlavor;
     }
 
-    getFlavorByApplicationVersion(version) {
+    getFlavorsByApplicationVersion(version) {
         const filteredFlavors = this.flavors.filter((flavor) => {
-            const { supportedApplicationVersions } = flavor.toJSON();
+            const supportedApplicationVersions = flavor.prop("supportedApplicationVersions");
             return (
                 !supportedApplicationVersions ||
                 (supportedApplicationVersions && supportedApplicationVersions.includes(version))