Skip to content

Commit

Permalink
use toJSON method, remove old commented code
Browse files Browse the repository at this point in the history
  • Loading branch information
pranabdas committed Jul 29, 2023
1 parent 8e32e87 commit a0134b4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@exabyte-io/code.js": "2023.7.11-0",
"@exabyte-io/eslint-config": "^2022.11.17-0",
"@exabyte-io/made.js": "2022.6.15-0",
"@exabyte-io/application-flavors.js": "git+https://github.com/Exabyte-io/application-flavors#f5067567d53111b4783912a7b05707a2f4dbb8e6",
"@exabyte-io/application-flavors.js": "git+https://github.com/Exabyte-io/application-flavors#02cb9dd629101c74567c662d6ccb7277613ff27e",
"chai": "^4.3.4",
"eslint": "7.32.0",
"eslint-config-airbnb": "19.0.2",
Expand Down
5 changes: 1 addition & 4 deletions src/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,14 @@ export class Application extends NamedDefaultableInMemoryEntity {
return new this.constructor.Executable({ ...tree[key], name: key });
});
const allowedExecutables = executableList.filter((exe) => {
const { supportedApplicationVersions } = exe._json;
const { supportedApplicationVersions } = exe.toJSON();
return (
!supportedApplicationVersions ||
(supportedApplicationVersions &&
supportedApplicationVersions.includes(this.prop("version")))
);
});
return allowedExecutables;
// return Object.keys(tree).map((key) => {
// return new this.constructor.Executable({ ...tree[key], name: key });
// });
}

get hasAdvancedComputeOptions() {
Expand Down

0 comments on commit a0134b4

Please sign in to comment.