SOF-6631: simplify application version filter and bump application-fl…

…avors
Exabyte-io · Aug 26, 2023 · bb5cb74 · bb5cb74
1 parent 018bda5
commit bb5cb74
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -47,7 +47,7 @@
         "@exabyte-io/code.js": "2023.8.10-0",
         "@exabyte-io/eslint-config": "^2022.11.17-0",
         "@exabyte-io/made.js": "2022.6.15-0",
-        "@exabyte-io/application-flavors.js": "git+https://github.com/Exabyte-io/application-flavors#de2c98f03a68ba740c26c5e4e0ffb1ca639c2deb",
+        "@exabyte-io/application-flavors.js": "2023.8.26-0",
         "chai": "^4.3.4",
         "eslint": "7.32.0",
         "eslint-config-airbnb": "19.0.2",

diff --git a/src/application.js b/src/application.js
@@ -101,8 +101,7 @@ export class Application extends NamedDefaultableInMemoryEntity {
                 const { supportedApplicationVersions } = tree[key];
                 return (
                     !supportedApplicationVersions ||
-                    (supportedApplicationVersions &&
-                        supportedApplicationVersions.includes(this.prop("version")))
+                    supportedApplicationVersions.includes(this.prop("version"))
                 );
             })
             .map((key) => {

diff --git a/src/executable.js b/src/executable.js
@@ -45,10 +45,7 @@ export class Executable extends mix(NamedDefaultableInMemoryEntity).with(Runtime
     getFlavorsByApplicationVersion(version) {
         const filteredFlavors = this.flavors.filter((flavor) => {
             const supportedApplicationVersions = flavor.prop("supportedApplicationVersions");
-            return (
-                !supportedApplicationVersions ||
-                (supportedApplicationVersions && supportedApplicationVersions.includes(version))
-            );
+            return !supportedApplicationVersions || supportedApplicationVersions.includes(version);
         });
 
         return filteredFlavors;